test(engine): add ffprobe-unavailable fallback regression tests#379
Merged
vanceingalls merged 1 commit intomainfrom Apr 23, 2026
Merged
test(engine): add ffprobe-unavailable fallback regression tests#379vanceingalls merged 1 commit intomainfrom
vanceingalls merged 1 commit intomainfrom
Conversation
This was referenced Apr 21, 2026
Collaborator
Author
This was referenced Apr 21, 2026
Merged
perf(producer): hdr benchmark harness — --tags filter, peak heap/RSS tracking, bench:hdr script
#382
Merged
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
0294c06 to
cc0422f
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
2163cd0 to
ca9c359
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
cc0422f to
8638446
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
ca9c359 to
d8c43e8
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
2 times, most recently
from
dad30f7 to
b3cd341
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
1733e38 to
6881964
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
b3cd341 to
25fb68e
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
1655176 to
16e2fa4
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
72f4d29 to
2196dec
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
16e2fa4 to
58f97e9
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
2196dec to
2c19da9
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
58f97e9 to
ea05258
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
2c19da9 to
40e2154
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
ea05258 to
b4fa284
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
40e2154 to
efe5bcb
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
from
b4fa284 to
193ed00
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
2 times, most recently
from
633de87 to
ef05bfc
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
2 times, most recently
from
ff0f25b to
e24208f
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
2 times, most recently
from
1b05a9e to
4c7b80a
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
2 times, most recently
from
2f4a04b to
cd80985
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
2 times, most recently
from
5512a6a to
c0836ce
Compare
vanceingalls
force-pushed
the
vance/shader-midpoint-tests
branch
3 times, most recently
from
66d4398 to
7b9eb89
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
c0836ce to
f82f2cb
Compare
vanceingalls
changed the base branch from
vance/shader-midpoint-tests
to
graphite-base/379
vanceingalls
force-pushed
the
graphite-base/379
branch
from
7b9eb89 to
4101cb7
Compare
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
f82f2cb to
3aca369
Compare
Mock node:child_process.spawn to surface ENOENT and verify that: - extractMediaMetadata falls back to PNG cICP metadata for image inputs - extractMediaMetadata rethrows for non-image inputs lacking a still-image fallback - extractAudioMetadata + analyzeKeyframeIntervals propagate the install-hint error verbatim Closed gap from hdr-followups Chunk 9B.
vanceingalls
force-pushed
the
vance/ffprobe-fallback-tests
branch
from
3aca369 to
f5be292
Compare
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mock
node:child_process.spawnto surfaceENOENTand verify ffprobe's three callers behave correctly when ffprobe is missing.Why
Chunk 9Bofplans/hdr-followups.md. The PNG cICP fallback inextractMediaMetadatawas added to support environments without ffprobe, but no test pinned the behavior — silently regressing it would break HDR image support on any system without ffprobe installed.What changed
packages/engine/src/utils/ffprobe.test.ts: mockschild_process.spawnto surfaceENOENTand asserts:extractMediaMetadatafalls back to PNG cICP metadata for image inputs.extractMediaMetadatarethrows for non-image inputs lacking a still-image fallback.extractAudioMetadata+analyzeKeyframeIntervalspropagate the install-hint error verbatim.Test plan
Stack
Chunk 9B of
plans/hdr-followups.md. Test-only change, independent of all other chunks.